mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
octeontx2-af: Fix CQ enable state tracking after AQ writes
Use the CQ context's ena field when updating the CQ enable bitmap.
The current code reads rq.ena, which overlaps bit 0 of the CQ base address
and can leave the bitmap out of sync with the hardware context. This can
cause enabled CQs to be skipped during teardown.
Use sq.ena for the SQ bitmap update as well, so each queue type reads
its own context.
Fixes: 557dd485ea ("octeontx2-af: Support for disabling NIX RQ/SQ/CQ contexts")
Signed-off-by: Alok Tiwari <[email protected]>
Reviewed-by: Ratheesh Kannoth <[email protected]>
Reviewed-by: Sunil Goutham <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Paolo Abeni <[email protected]>
This commit is contained in:
@@ -1239,7 +1239,7 @@ static int rvu_nix_blk_aq_enq_inst(struct rvu *rvu, struct nix_hw *nix_hw,
|
||||
__clear_bit(req->qidx, pfvf->rq_bmap);
|
||||
}
|
||||
if (req->ctype == NIX_AQ_CTYPE_SQ) {
|
||||
ena = (req->rq.ena & req->sq_mask.ena) |
|
||||
ena = (req->sq.ena & req->sq_mask.ena) |
|
||||
(test_bit(req->qidx, pfvf->sq_bmap) &
|
||||
~req->sq_mask.ena);
|
||||
if (ena)
|
||||
@@ -1248,7 +1248,7 @@ static int rvu_nix_blk_aq_enq_inst(struct rvu *rvu, struct nix_hw *nix_hw,
|
||||
__clear_bit(req->qidx, pfvf->sq_bmap);
|
||||
}
|
||||
if (req->ctype == NIX_AQ_CTYPE_CQ) {
|
||||
ena = (req->rq.ena & req->cq_mask.ena) |
|
||||
ena = (req->cq.ena & req->cq_mask.ena) |
|
||||
(test_bit(req->qidx, pfvf->cq_bmap) &
|
||||
~req->cq_mask.ena);
|
||||
if (ena)
|
||||
|
||||
Reference in New Issue
Block a user