mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
minmax.h: use BUILD_BUG_ON_MSG() for the lo < hi test in clamp()
Use BUILD_BUG_ON_MSG(statically_true(ulo > uhi), ...) for the sanity check of the bounds in clamp(). Gives better error coverage and one less expansion of the arguments. Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: David Laight <[email protected]> Cc: Andy Shevchenko <[email protected]> Cc: Arnd Bergmann <[email protected]> Cc: Christoph Hellwig <[email protected]> Cc: Dan Carpenter <[email protected]> Cc: Jason A. Donenfeld <[email protected]> Cc: Jens Axboe <[email protected]> Cc: Lorenzo Stoakes <[email protected]> Cc: Mateusz Guzik <[email protected]> Cc: Matthew Wilcox <[email protected]> Cc: Pedro Falcato <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
This commit is contained in:
committed by
Andrew Morton
parent
b280bb27a9
commit
a5743f32ba
@@ -106,8 +106,7 @@
|
||||
__auto_type uval = (val); \
|
||||
__auto_type ulo = (lo); \
|
||||
__auto_type uhi = (hi); \
|
||||
static_assert(__builtin_choose_expr(__is_constexpr((lo) > (hi)), \
|
||||
(lo) <= (hi), true), \
|
||||
BUILD_BUG_ON_MSG(statically_true(ulo > uhi), \
|
||||
"clamp() low limit " #lo " greater than high limit " #hi); \
|
||||
BUILD_BUG_ON_MSG(!__types_ok3(uval, ulo, uhi), \
|
||||
"clamp("#val", "#lo", "#hi") signedness error"); \
|
||||
|
||||
Reference in New Issue
Block a user