From e0bec04067a9196ab27e9237fd605fdb4a688c7f Mon Sep 17 00:00:00 2001 From: bui duc phuc Date: Fri, 28 Aug 2026 16:27:34 +0700 Subject: [PATCH] chardev: check return value of kobject_set_name() in __register_chrdev() The kobject_set_name() function can fail and return -ENOMEM if memory allocation fails. While all other functions called inside __register_chrdev() are properly checked for errors, kobject_set_name() was missing this check. Add the error check for kobject_set_name() and jump to the 'out' label on failure to maintain consistency and ensure proper error handling. Found by manual code inspection. Reviewed-by: Jan Kara Signed-off-by: bui duc phuc Link: https://patch.msgid.link/20260828092734.600911-1-phucduc.bui@gmail.com Signed-off-by: Christian Brauner (Amutable) --- fs/char_dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/char_dev.c b/fs/char_dev.c index 00229e25c10f..5ce5423f6c99 100644 --- a/fs/char_dev.c +++ b/fs/char_dev.c @@ -280,7 +280,9 @@ int __register_chrdev(unsigned int major, unsigned int baseminor, cdev->owner = fops->owner; cdev->ops = fops; - kobject_set_name(&cdev->kobj, "%s", name); + err = kobject_set_name(&cdev->kobj, "%s", name); + if (err) + goto out; err = cdev_add(cdev, MKDEV(cd->major, baseminor), count); if (err)