mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
If the request to be cancelled is being run by io-wq, io_async_cancel_one() flags the work, signals the worker and returns -EALREADY. Since commitccbf726171("io_uring: perform poll removal even if async work removal is successful") io_try_cancel() goes on regardless, as poll may be armed for the request. If it isn't, and nothing else turns up, the result is the -ENOENT of the last search. __io_async_cancel() makes up for that. On -ENOENT it tries the io-wq of every task that uses the ring, and that of the caller is one of them. So the work is found a second time, and the result is -EALREADY after all. Unless the worker is done with it by then. If the work is flagged before io_wq_submit_work() looks at IO_WQ_WORK_CANCEL, all the worker does is to queue the request to be failed by task work. Then it isn't anywhere to be found until the task work has run, and - IORING_REGISTER_SYNC_CANCEL returns -ENOENT, - IORING_OP_ASYNC_CANCEL completes with -ENOENT, for a request that they have just cancelled, and that completes with -ECANCELED. With a read of an empty pipe, IOSQE_ASYNC, and a sync cancel right behind it, 1 to 3 of 1,000,000 calls return -ENOENT, and 50 to 110 with IORING_SETUP_DEFER_TASKRUN (4 CPUs, KVM). Nothing is written to the pipe, and all of these reads end with -ECANCELED. Remember that the work was found. IORING_OP_ASYNC_CANCEL completes with -EALREADY, as it does if the worker is a bit slower. For IORING_REGISTER_SYNC_CANCEL it means to try again, which ends with 0. The result of a linked timeout, which calls io_try_cancel() by itself, and the number that is returned for IORING_ASYNC_CANCEL_ALL and _ANY don't change. Fixes:ccbf726171("io_uring: perform poll removal even if async work removal is successful") Assisted-by: LLM Signed-off-by: Josef Bacik <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jens Axboe <[email protected]>
63 lines
1.9 KiB
C
63 lines
1.9 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#ifndef IORING_CANCEL_H
|
|
#define IORING_CANCEL_H
|
|
|
|
#include <linux/io_uring_types.h>
|
|
|
|
struct io_cancel_data {
|
|
struct io_ring_ctx *ctx;
|
|
u64 data;
|
|
struct file *file;
|
|
u8 opcode;
|
|
u32 flags;
|
|
int seq;
|
|
/* io_try_cancel() has found it being run by io-wq, and flagged it */
|
|
bool running;
|
|
};
|
|
|
|
int io_async_cancel_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe);
|
|
int io_async_cancel(struct io_kiocb *req, unsigned int issue_flags);
|
|
|
|
int io_try_cancel(struct io_uring_task *tctx, struct io_cancel_data *cd,
|
|
unsigned int issue_flags);
|
|
|
|
int io_sync_cancel(struct io_ring_ctx *ctx, void __user *arg);
|
|
bool io_cancel_req_match(struct io_kiocb *req, struct io_cancel_data *cd);
|
|
bool io_match_task_safe(struct io_kiocb *head, struct io_uring_task *tctx,
|
|
bool cancel_all);
|
|
|
|
bool io_cancel_remove_all(struct io_ring_ctx *ctx, struct io_uring_task *tctx,
|
|
struct hlist_head *list, bool cancel_all,
|
|
bool (*cancel)(struct io_kiocb *));
|
|
int io_cancel_remove(struct io_ring_ctx *ctx, struct io_cancel_data *cd,
|
|
unsigned int issue_flags, struct hlist_head *list,
|
|
bool (*cancel)(struct io_kiocb *));
|
|
|
|
/* io_uring_try_cancel_requests() flags */
|
|
enum {
|
|
/* match all requests, not just REQ_F_INFLIGHT */
|
|
IO_CANCEL_ALL = 1,
|
|
/* ignore timeouts */
|
|
IO_CANCEL_KEEP_TIMEOUTS = 2,
|
|
/* called by the SQPOLL thread */
|
|
IO_CANCEL_SQPOLL = 4,
|
|
};
|
|
|
|
__cold bool io_uring_try_cancel_requests(struct io_ring_ctx *ctx,
|
|
struct io_uring_task *tctx,
|
|
unsigned int flags);
|
|
__cold void io_uring_cancel_generic(bool cancel_all, struct io_sq_data *sqd);
|
|
__cold bool io_cancel_ctx_cb(struct io_wq_work *work, void *data);
|
|
|
|
static inline bool io_cancel_match_sequence(struct io_kiocb *req, int sequence)
|
|
{
|
|
if (req->cancel_seq_set && sequence == req->work.cancel_seq)
|
|
return true;
|
|
|
|
req->cancel_seq_set = true;
|
|
req->work.cancel_seq = sequence;
|
|
return false;
|
|
}
|
|
|
|
#endif
|