Files
Anuj Gupta 45b716456d io_uring/dma-buf: don't fail fixed buffers without dma-buf support
io_attach_dmabuf_map() is called for every fixed read/write, but returns
-EOPNOTSUPP when CONFIG_DMA_SHARED_BUFFER is disabled before checking
whether the request uses a dma-buf at all. So READ_FIXED and WRITE_FIXED
fail for ordinary registered buffers. Check REQ_F_DMABUF first.

Fixes: 62e4bf5b25 ("io_uring/rsrc: add dmabuf backed registered buffers")
Signed-off-by: Anuj Gupta <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jens Axboe <[email protected]>
2026-10-22 09:27:00 -06:00

77 lines
1.8 KiB
C

// SPDX-License-Identifier: GPL-2.0
#ifndef IOU_DMA_BUF_H
#define IOU_DMA_BUF_H
#include <linux/dma-buf-io.h>
#include <linux/io_uring_types.h>
#include "rsrc.h"
struct io_buf_dma {
struct dma_buf_io_ctx *ctx;
struct file *target_file;
};
int __io_register_dmabuf(struct io_ring_ctx *ctx,
struct io_uring_regbuf_desc *desc,
struct io_mapped_ubuf *imu);
static inline void io_detach_dmabuf_map(struct io_kiocb *req)
{
if (!IS_ENABLED(CONFIG_DMA_SHARED_BUFFER))
return;
if (!(req->flags & REQ_F_DMABUF) || !req->dmabuf_map)
return;
dma_buf_io_map_drop(req->dmabuf_map);
req->dmabuf_map = NULL;
}
static inline int io_attach_dmabuf_map(struct io_kiocb *req,
struct iov_iter *iter,
unsigned issue_flags)
{
bool nowait = issue_flags & IO_URING_F_NONBLOCK;
struct dma_buf_io_map *map;
struct io_buf_dma *bd;
if (!(req->flags & REQ_F_DMABUF))
return 0;
if (!IS_ENABLED(CONFIG_DMA_SHARED_BUFFER))
return -EOPNOTSUPP;
bd = req->buf_node->buf->priv;
map = dma_buf_io_get_map(bd->ctx, nowait);
if (unlikely(IS_ERR(map)))
return PTR_ERR(map);
req->dmabuf_map = map;
iter->dmabuf_map = map;
return 0;
}
static inline int io_import_dmabuf_map(struct io_kiocb *req,
int ddir, struct iov_iter *iter,
struct io_mapped_ubuf *imu,
size_t len, size_t offset)
{
struct io_buf_dma *bd = imu->priv;
if (!IS_ENABLED(CONFIG_DMA_SHARED_BUFFER))
return -EOPNOTSUPP;
if (req->file != bd->target_file)
return -EBADF;
req->flags |= REQ_F_DMABUF;
iov_iter_dmabuf_map(iter, ddir, NULL, offset, len);
return 0;
}
static inline int io_register_dmabuf(struct io_ring_ctx *ctx,
struct io_uring_regbuf_desc *desc,
struct io_mapped_ubuf *imu)
{
if (!IS_ENABLED(CONFIG_DMA_SHARED_BUFFER))
return -EOPNOTSUPP;
return __io_register_dmabuf(ctx, desc, imu);
}
#endif /* IOU_DMA_BUF_H */