mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
In event_hist_trigger_parse() and hist_unreg_all(), the histogram
registration and unregistration paths look up find_synth_event() using
trace_event_name(file->event_call) and adjust se->ref if a match is
found.
Because find_synth_event() only compares the event basename, registering
or removing a histogram on a non-synthetic trace event whose basename
matches a synthetic event erroneously modifies the synthetic event's
reference count. If a histogram is registered on the non-synthetic
event before the synthetic event is created and removed afterwards,
se->ref is decremented without a matching increment, allowing the
synthetic event to be freed while an active histogram action still holds
a pointer to it.
Introduce find_synth_event_call() to verify that &se->call matches
file->event_call before adjusting se->ref.
Fixes: 4b147936fa ("tracing: Add support for 'synthetic' events")
Cc: [email protected]
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Lee Jones <[email protected]>
Signed-off-by: Steven Rostedt <[email protected]>
43 lines
973 B
C
43 lines
973 B
C
// SPDX-License-Identifier: GPL-2.0
|
|
#ifndef __TRACE_SYNTH_H
|
|
#define __TRACE_SYNTH_H
|
|
|
|
#include "trace_dynevent.h"
|
|
|
|
#define SYNTH_SYSTEM "synthetic"
|
|
#define SYNTH_FIELDS_MAX 64
|
|
|
|
#define STR_VAR_LEN_MAX MAX_FILTER_STR_VAL /* must be multiple of sizeof(u64) */
|
|
|
|
struct synth_field {
|
|
char *type;
|
|
char *name;
|
|
size_t size;
|
|
unsigned int offset;
|
|
unsigned int field_pos;
|
|
bool is_signed;
|
|
bool is_string;
|
|
bool is_dynamic;
|
|
bool is_stack;
|
|
};
|
|
|
|
struct synth_event {
|
|
struct dyn_event devent;
|
|
int ref;
|
|
char *name;
|
|
struct synth_field **fields;
|
|
unsigned int n_fields;
|
|
struct synth_field **dynamic_fields;
|
|
unsigned int n_dynamic_fields;
|
|
unsigned int n_u64;
|
|
struct trace_event_class class;
|
|
struct trace_event_call call;
|
|
struct tracepoint *tp;
|
|
struct module *mod;
|
|
};
|
|
|
|
extern struct synth_event *find_synth_event(const char *name);
|
|
extern struct synth_event *find_synth_event_call(struct trace_event_call *call);
|
|
|
|
#endif /* __TRACE_SYNTH_H */
|