mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
This reverts commit fcbfaffee5.
Turns out that vfio is a crazy beast and people have been "relying" on
the bind/unbind debugging feature as a way to handle passing through
devices to guest instances. Because of this (https://xkcd.com/1172/),
let's revert the feature for now until we can figure out a more agreeable
way to handle this such that normal workflows do not taint the kernel.
Odds are something like what Uwe proposes at:
https://lore.kernel.org/lkml/[email protected]/
will be the best way forward and will be revisited after for after 7.4.
The feature was originally intended to stem the flow of unnecessary
fuzzing reports of "broken" drivers where random devices were being
bound to random drivers and of course things were going wrong. The main
syzbot tool is now not doing this anymore, and hopefully no one else
starts it up again (but in this madness of LLMs these days, you can't be
sure.)
Thanks to everyone for telling me just how wrong I was to implement
this, I appreciated the feedback :)
Link: https://lore.kernel.org/all/[email protected]/
To: Jonathan Corbet <[email protected]>
To: Shuah Khan <[email protected]>
To: Randy Dunlap <[email protected]>
To: "Rafael J. Wysocki" <[email protected]>
To: Danilo Krummrich <[email protected]>
To: Johan Hovold <[email protected]>
To: Steven Rostedt <[email protected]>
To: Masami Hiramatsu <[email protected]>
To: Mathieu Desnoyers <[email protected]>
Reported-by: Leon Romanovsky <[email protected]>
Reported-by: Jason Gunthorpe <[email protected]>
Reported-by: Michal Pecio <[email protected]>
Reported-by: "Uwe Kleine-König" <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
[ Revert the change in Documentation/admin-guide/tainted-kernels.rst.
- Danilo ]
Signed-off-by: Danilo Krummrich <[email protected]>
236 lines
4.2 KiB
Bash
Executable File
236 lines
4.2 KiB
Bash
Executable File
#! /bin/sh
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
#
|
|
# Randy Dunlap <[email protected]>, 2018
|
|
# Thorsten Leemhuis <[email protected]>, 2018
|
|
|
|
usage()
|
|
{
|
|
cat <<EOF
|
|
usage: ${0##*/}
|
|
${0##*/} <int>
|
|
|
|
Call without parameters to decode /proc/sys/kernel/tainted.
|
|
|
|
Call with a positive integer as parameter to decode a value you
|
|
retrieved from /proc/sys/kernel/tainted on another system.
|
|
|
|
EOF
|
|
}
|
|
|
|
if [ "$1"x != "x" ]; then
|
|
if [ "$1"x == "--helpx" ] || [ "$1"x == "-hx" ] ; then
|
|
usage
|
|
exit 1
|
|
elif [ $1 -ge 0 ] 2>/dev/null ; then
|
|
taint=$1
|
|
else
|
|
echo "Error: Parameter '$1' not a positive integer. Aborting." >&2
|
|
exit 1
|
|
fi
|
|
else
|
|
TAINTFILE="/proc/sys/kernel/tainted"
|
|
if [ ! -r $TAINTFILE ]; then
|
|
echo "No file: $TAINTFILE"
|
|
exit
|
|
fi
|
|
|
|
taint=`cat $TAINTFILE`
|
|
fi
|
|
|
|
if [ $taint -eq 0 ]; then
|
|
echo "Kernel not Tainted"
|
|
exit
|
|
else
|
|
echo "Kernel is \"tainted\" for the following reasons:"
|
|
fi
|
|
|
|
T=$taint
|
|
out=
|
|
|
|
addout() {
|
|
out=$out$1
|
|
}
|
|
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout "G"
|
|
else
|
|
addout "P"
|
|
echo " * proprietary module was loaded (#0)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "F"
|
|
echo " * module was force loaded (#1)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "S"
|
|
echo " * kernel running on an out of specification system (#2)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "R"
|
|
echo " * module was force unloaded (#3)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "M"
|
|
echo " * processor reported a Machine Check Exception (MCE) (#4)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "B"
|
|
echo " * bad page referenced or some unexpected page flags (#5)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "U"
|
|
echo " * taint requested by userspace application (#6)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "D"
|
|
echo " * kernel died recently, i.e. there was an OOPS or BUG (#7)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "A"
|
|
echo " * an ACPI table was overridden by user (#8)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "W"
|
|
echo " * kernel issued warning (#9)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "C"
|
|
echo " * staging driver was loaded (#10)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "I"
|
|
echo " * workaround for bug in platform firmware applied (#11)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "O"
|
|
echo " * externally-built ('out-of-tree') module was loaded (#12)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "E"
|
|
echo " * unsigned module was loaded (#13)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "L"
|
|
echo " * soft lockup occurred (#14)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "K"
|
|
echo " * kernel has been live patched (#15)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "X"
|
|
echo " * auxiliary taint, defined for and used by distros (#16)"
|
|
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "T"
|
|
echo " * kernel was built with the struct randomization plugin (#17)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "N"
|
|
echo " * an in-kernel test (such as a KUnit test) has been run (#18)"
|
|
fi
|
|
|
|
T=`expr $T / 2`
|
|
if [ `expr $T % 2` -eq 0 ]; then
|
|
addout " "
|
|
else
|
|
addout "J"
|
|
echo " * fwctl's mutating debug interface was used (#19)"
|
|
fi
|
|
echo "Raw taint value as int/string: $taint/'$out'"
|
|
|
|
# report on any tainted loadable modules
|
|
[ "$1" = "" ] && [ -r /sys/module/ ] && \
|
|
cnt=`grep [A-Z] /sys/module/*/taint | wc -l` || cnt=0
|
|
|
|
if [ $cnt -ne 0 ]; then
|
|
echo
|
|
echo "Tainted modules:"
|
|
for dir in `ls /sys/module` ; do
|
|
if [ -r /sys/module/$dir/taint ]; then
|
|
modtnt=`cat /sys/module/$dir/taint`
|
|
[ "$modtnt" = "" ] || echo " * $dir ($modtnt)"
|
|
fi
|
|
done
|
|
fi
|
|
|
|
echo
|
|
echo "For a more detailed explanation of the various taint flags see"
|
|
echo " Documentation/admin-guide/tainted-kernels.rst in the Linux kernel sources"
|
|
echo " or https://kernel.org/doc/html/latest/admin-guide/tainted-kernels.html"
|
|
#EOF#
|