Guixin Liu
d25f15a76c
checkpatch: don't flag ACQUIRE_ERR() assignments in if conditions
...
ACQUIRE_ERR() and its wrappers, PM_RUNTIME_ACQUIRE_ERR() and
IIO_DEV_ACQUIRE_FAILED(), report whether a conditional cleanup.h guard was
acquired, and drivers consume the result directly in an if condition:
if ((rc = ACQUIRE_ERR(mutex_intr, &lock)))
return rc;
That combined form is the established style at the 49 in-tree call sites
under drivers/cxl and drivers/pci/tsm.c, so ASSIGN_IN_IF fires there only
as a false positive, and every patch touching those lines carries noise
that reviewers have to wave off manually.
Skip the check only when every assignment in the condition assigns the
result of such a call, matched by the *_ACQUIRE_ERR() / *_ACQUIRE_FAILED()
naming convention of its wrappers. Plain assignments, mixed conditions
and near-miss identifiers still get flagged.
Link: https://lore.kernel.org/[email protected]
Signed-off-by: Guixin Liu <[email protected] >
Signed-off-by: Andrew Morton <[email protected] >
Suggested-by: Alison Schofield <[email protected] >
Acked-by: Joe Perches <[email protected] >
Assisted-by: LLM
Cc: Andy Whitcroft <[email protected] >
Cc: Jonathan Cameron <[email protected] >
2026-10-13 21:25:47 -07:00
..
2026-01-09 19:01:42 +08:00
2025-03-15 21:22:52 +09:00
2026-08-05 14:46:50 +02:00
2026-06-16 16:33:57 +05:30
2026-09-22 10:30:17 -07:00
2026-08-10 20:17:56 -07:00
2026-08-14 15:43:24 -05:00
2026-01-29 17:12:13 -07:00
2026-05-14 09:24:32 -07:00
2026-07-28 21:11:50 -07:00
2025-12-22 16:35:54 +00:00
2026-02-26 11:53:05 -07:00
2024-10-07 02:12:27 +09:00
2024-11-19 13:57:03 -08:00
2026-08-14 21:33:20 +02:00
2026-08-31 17:50:06 -07:00
2026-08-18 12:18:33 -07:00
2026-07-29 16:21:42 -07:00
2026-07-31 14:19:36 +02:00
2025-08-18 10:45:43 -06:00
2025-03-20 07:02:21 -04:00
2025-10-29 08:46:05 -04:00
2026-05-28 21:24:48 -07:00
2025-10-04 09:05:23 -07:00
2024-07-16 01:08:37 +09:00
2026-02-13 14:23:06 -05:00
2026-01-14 14:13:41 +01:00
2025-07-23 11:57:05 +02:00
2026-03-20 21:43:56 +01:00
2026-01-18 10:32:03 +01:00
2026-10-13 21:25:47 -07:00
2026-10-06 19:03:02 -07:00
2026-04-05 09:21:31 +02:00
2026-08-23 22:12:10 +02:00
2026-08-05 14:52:00 +02:00
2025-06-17 10:44:07 +02:00
2026-01-22 15:30:48 -07:00
2026-03-08 11:06:53 +01:00
2026-03-27 21:19:45 -07:00
2026-03-27 21:19:48 -07:00
2024-11-27 09:38:27 +09:00
2025-10-24 16:43:14 -04:00
2025-10-24 16:43:14 -04:00
2025-03-16 22:30:46 -07:00
2025-08-28 15:25:48 -07:00
2025-10-14 14:45:20 -07:00
2024-12-11 20:13:00 -08:00
2026-01-21 12:36:32 -08:00
2025-03-10 09:29:08 -07:00
2025-03-15 21:22:52 +09:00
2026-06-09 04:13:23 +02:00
2026-09-18 21:43:38 -07:00
2026-05-28 21:24:42 -07:00
2024-09-01 17:59:01 -07:00
2025-04-25 15:54:24 +02:00
2024-12-10 12:04:19 +00:00
2026-08-04 22:34:06 +02:00
2024-07-20 13:34:54 +09:00
2025-03-07 19:58:05 -08:00
2026-06-10 13:37:05 -05:00
2026-08-05 14:59:45 +02:00
2024-11-27 09:38:27 +09:00
2026-02-03 15:29:17 -07:00
2026-01-20 15:57:06 -07:00
2024-07-15 03:13:32 +09:00
2026-08-05 14:59:46 +02:00
2024-09-01 20:43:28 -07:00
2026-02-13 14:24:01 -05:00
2026-03-24 21:42:37 +00:00
2026-09-12 20:01:13 +02:00
2026-06-04 09:26:57 +02:00
2026-08-06 22:01:28 -07:00
2026-08-23 21:27:17 +02:00
2025-03-04 09:40:13 -08:00
2024-11-28 08:10:23 +09:00
2026-05-26 09:44:54 +02:00
2026-01-05 16:43:33 +01:00
2024-04-02 17:41:22 +02:00
2025-01-10 23:01:21 +09:00
2024-06-26 00:18:57 +09:00
2026-02-03 20:58:12 -06:00
2025-07-21 21:40:57 -07:00
2024-11-28 08:11:55 +09:00
2026-05-27 01:54:22 +02:00
2025-06-02 16:00:26 -07:00
2025-07-29 17:17:46 -07:00
2026-06-15 14:31:58 +05:30
2026-04-29 18:03:49 -07:00
2025-11-08 12:17:58 +01:00
2025-01-11 02:36:32 +09:00
2026-03-30 07:38:26 +02:00
2024-11-27 09:38:27 +09:00
2026-05-29 13:44:29 -07:00
2025-05-29 08:10:01 -07:00
2026-04-02 17:50:40 +02:00
2026-02-10 11:26:21 -08:00
2026-06-02 18:41:50 -07:00
2026-08-03 07:12:39 +02:00
2026-05-27 15:20:05 -07:00
2026-07-31 16:57:48 +05:30
2025-08-26 12:00:17 -07:00
2026-09-12 20:01:19 +02:00
2024-09-07 17:24:08 +09:00
2026-08-06 13:29:02 +02:00
2026-08-23 22:12:10 +02:00
2025-07-22 20:15:56 -04:00
2024-10-03 16:07:51 -04:00
2026-08-03 14:08:42 +02:00
2026-08-03 14:08:42 +02:00
2026-08-03 14:08:42 +02:00
2024-10-28 00:27:16 +01:00
2024-09-05 22:44:18 +02:00
2026-06-19 09:39:50 +02:00
2026-08-12 09:36:26 +02:00
2024-11-28 08:11:56 +09:00
2025-03-15 21:19:44 +09:00
2026-03-24 21:42:37 +00:00
2026-09-12 20:01:18 +02:00
2026-01-11 06:09:11 -10:00
2026-10-13 21:25:43 -07:00
2024-09-20 19:49:52 +03:00
2024-09-10 13:56:37 +09:00
2026-07-27 17:18:00 +02:00
2024-06-28 15:23:38 +02:00
2026-08-05 14:31:55 +02:00
2026-05-06 08:33:07 +02:00
2026-01-23 13:34:45 -05:00
2024-04-23 00:09:41 +09:00
2026-04-29 15:53:19 -07:00
2026-03-30 10:36:11 -06:00
2024-09-20 09:21:52 +09:00
2024-09-01 20:43:27 -07:00