mm: page_isolation: do not take slab pages for free

page_is_unmovable() regards a page with a reference count of zero as free
or about to be freed. Since slab allocates frozen pages, they will
be wrongly considered to be freed if order 0 (higher-order compound
pages are caught earlier).

If such slabs are the only unmovable pages of a memory block, memory
offlining now isolates the block, this can lead to offline_pages()
looping without progress.

Thus detect the slab pages as removable to return -EBUSY, as would
happen before commit 9aec2fb0fd ("slab: allocate frozen pages").

Fixes: 9aec2fb0fd ("slab: allocate frozen pages")
Cc: [email protected]
Assisted-by: LLM
Signed-off-by: Josef Bacik <[email protected]>
Signed-off-by: David Hildenbrand (Arm) <[email protected]>
Reviewed-by: Zi Yan <[email protected]>
Reviewed-by: Johannes Weiner <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Vlastimil Babka (SUSE) <[email protected]>
This commit is contained in:
Josef Bacik
2026-11-10 09:18:49 +01:00
committed by Vlastimil Babka (SUSE)
parent c028ecdf15
commit 2132688693
2 changed files with 14 additions and 0 deletions
+7
View File
@@ -1832,6 +1832,13 @@ static int scan_movable_pages(unsigned long start, unsigned long end,
if (PageOffline(page) && page_count(page))
return -EBUSY;
/*
* A page that was allocated, but was not a slab page yet, when
* its pageblock was isolated.
*/
if (PageSlab(page))
return -EBUSY;
folio = page_folio(page);
if (!folio_test_hugetlb(folio))
continue;
+7
View File
@@ -74,6 +74,13 @@ bool page_is_unmovable(struct zone *zone, struct page *page,
return false;
}
/*
* Slab pages are frozen: do not take their reference count of zero
* for that of a free page.
*/
if (PageSlab(page))
return true;
/*
* We can't use page_count without pin a page
* because another CPU can free compound page.