mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
iavf: fix ASQ command buffer leak on init failure
iavf_alloc_adminq_asq_ring() allocates cmd_buf before the remaining ASQ
resources. If iavf_alloc_asq_bufs() or iavf_config_asq_regs() fails, the
unwind path elides cmd_buf while freeing the other allocations.
The ASQ count is not set until initialization succeeds, so the shutdown
path cannot reclaim the buffer. Free cmd_buf in the common unwind path.
Fixes: d358aa9a7a ("i40evf: init code and hardware support")
Cc: [email protected]
Signed-off-by: Xuanqiang Luo <[email protected]>
Reviewed-by: Jedrzej Jagielski <[email protected]>
Reviewed-by: Aleksandr Loktionov <[email protected]>
Signed-off-by: Tony Nguyen <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
This commit is contained in:
committed by
Jakub Kicinski
parent
65f6ffb900
commit
2a1f106379
@@ -60,6 +60,7 @@ static enum iavf_status iavf_alloc_adminq_arq_ring(struct iavf_hw *hw)
|
||||
**/
|
||||
static void iavf_free_adminq_asq(struct iavf_hw *hw)
|
||||
{
|
||||
iavf_free_virt_mem(hw, &hw->aq.asq.cmd_buf);
|
||||
iavf_free_dma_mem(hw, &hw->aq.asq.desc_buf);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user