mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
ipc: only destroy orphaned shm segments on sysctl write
proc_ipc_dointvec_minmax_orphans() currently calls shm_destroy_orphaned() whenever shm_rmid_forced is set, including on sysctl reads. Reading /proc/sys/kernel/shm_rmid_forced should not take shm_ids rwsem for write and walk all segments. Only run the cleanup when the sysctl is written and the forced RMID policy is enabled. When shm_rmid_forced=1, monitoring tools that read /proc/sys/kernel/shm_rmid_forced trigger the cleanup on every read. Link: https://lore.kernel.org/all/?q=only+destroy+orphaned+shm+segments+on+sysctl+write Link: https://lore.kernel.org/[email protected] Signed-off-by: Jianlin Shi <[email protected]> Acked-by: Davidlohr Bueso <[email protected]> Cc: "Eric W. Biederman" <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
This commit is contained in:
committed by
Andrew Morton
parent
9f12170550
commit
36969d97fe
+1
-1
@@ -28,7 +28,7 @@ static int proc_ipc_dointvec_minmax_orphans(const struct ctl_table *table, int w
|
||||
|
||||
if (err < 0)
|
||||
return err;
|
||||
if (ns->shm_rmid_forced)
|
||||
if (write && ns->shm_rmid_forced)
|
||||
shm_destroy_orphaned(ns);
|
||||
return err;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user