mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
i40e: fix freeing of TX rings on RX allocation failure
When ethtool -G is used to change ring buffer sizes while the interface is
up, i40e_set_ringparam() allocates temporary TX and RX rings. If the RX
ring allocation fails, the error path at the free_tx label incorrectly
calls i40e_free_tx_resources(vsi->tx_rings[i]), freeing the live TX rings
instead of the temporary tx_rings[i].
Since the interface is still up, the next TX completion interrupt causes
i40e_clean_tx_irq() to dereference the freed ring descriptors, resulting in
a NULL pointer dereference in IRQ context and a kernel panic.
This can be reproduced on systems with Intel X710 NICs under memory
pressure, where the second port's DMA allocation fails after the first port
succeeds.
Fix by freeing the temporary tx_rings[i] in the error path instead of
the live vsi->tx_rings[i].
Fixes: 74608d17fe ("i40e: add support for XDP_TX action")
Signed-off-by: Filip Balluch <[email protected]>
Reviewed-by: Aleksandr Loktionov <[email protected]>
Tested-by: Alexander Nowlin <[email protected]>
Signed-off-by: Tony Nguyen <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
This commit is contained in:
committed by
Jakub Kicinski
parent
343869114a
commit
4957f66868
@@ -2249,7 +2249,7 @@ free_tx:
|
||||
if (tx_rings) {
|
||||
for (i = 0; i < tx_alloc_queue_pairs; i++) {
|
||||
if (i40e_active_tx_ring_index(vsi, i))
|
||||
i40e_free_tx_resources(vsi->tx_rings[i]);
|
||||
i40e_free_tx_resources(&tx_rings[i]);
|
||||
}
|
||||
kfree(tx_rings);
|
||||
tx_rings = NULL;
|
||||
|
||||
Reference in New Issue
Block a user