mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
mm: debug_page_alloc: fix NULL buf in debug_guardpage_minorder_setup
If the kernel command line includes "debug_guardpage_minorder" without an
equals sign (i.e., no value is provided), the early parameter parser
passes a NULL buf pointer to the setup function.
kstrtouint() does not perform a NULL check on its input and calls directly
into kstrtoull() which dereferences s[0] unconditionally, leading to a
NULL pointer dereference and early boot crash.
Additionally, the error path's pr_err("%s", buf) would also crash with a
NULL format argument.
Link: https://lore.kernel.org/[email protected]
Fixes: c0a32fc5a2 ("mm: more intensive memory corruption debugging")
Signed-off-by: Ye Liu <[email protected]>
Acked-by: Zi Yan <[email protected]>
Reviewed-by: John Hubbard <[email protected]>
Reviewed-by: Andrew Morton <[email protected]>
Cc: Johannes Weiner <[email protected]>
Cc: Michal Hocko <[email protected]>
Cc: Suren Baghdasaryan <[email protected]>
Cc: Vlastimil Babka <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
This commit is contained in:
@@ -22,8 +22,8 @@ static int __init debug_guardpage_minorder_setup(char *buf)
|
||||
{
|
||||
unsigned int res;
|
||||
|
||||
if (kstrtouint(buf, 10, &res) < 0 || res > MAX_PAGE_ORDER / 2) {
|
||||
pr_err("Bad debug_guardpage_minorder value: %s\n", buf);
|
||||
if (!buf || kstrtouint(buf, 10, &res) < 0 || res > MAX_PAGE_ORDER / 2) {
|
||||
pr_err("Bad debug_guardpage_minorder value: %s\n", buf ?: "(missing)");
|
||||
return 0;
|
||||
}
|
||||
_debug_guardpage_minorder = res;
|
||||
|
||||
Reference in New Issue
Block a user