mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
net: dcb: flush rewrite table on device unregister
In dcbnl_flush_dev(), which is called upon NETDEV_UNREGISTER for net
devices with dcbnl_ops, only entries in dcb_app_list matching
dev->ifindex are freed. The entries in dcb_rewr_list added via
dcb_setrewr() are not flushed.
This causes a memory leak of struct dcb_app_type nodes in dcb_rewr_list
when a DCB-capable net device is unregistered, and leaves stale entries
in the global rewrite table that could inappropriately match if another
net device later reuses the same ifindex.
Iterate over dcb_rewr_list in dcbnl_flush_dev() and remove and free all
entries matching dev->ifindex, mirroring the cleanup performed for
dcb_app_list.
This issue was found via LLM-assisted code review, confirmed by
reproducing the leaked rewrite table entry upon netdevice unregistration
in a User-Mode Linux (ARCH=um) environment, and verified in UML by
confirming that all rewrite table entries for the unregistered netdevice
are flushed.
Fixes: 622f1b2fae ("net: dcb: add new rewrite table")
Reviewed-by: Daniel Machon <[email protected]>
Tested-by: Daniel Machon <[email protected]>
Reviewed-by: Petr Machata <[email protected]>
Signed-off-by: Wenbo Sun <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
This commit is contained in:
committed by
Jakub Kicinski
parent
f2540da93a
commit
6836fa4001
@@ -2393,6 +2393,13 @@ static void dcbnl_flush_dev(struct net_device *dev)
|
||||
}
|
||||
}
|
||||
|
||||
list_for_each_entry_safe(itr, tmp, &dcb_rewr_list, list) {
|
||||
if (itr->ifindex == dev->ifindex) {
|
||||
list_del(&itr->list);
|
||||
kfree(itr);
|
||||
}
|
||||
}
|
||||
|
||||
spin_unlock_bh(&dcb_lock);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user