mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
mm: bdi: reset min_ratio after the sysfs attributes are gone
A write to /sys/class/bdi/<dev>/min_ratio (or min_ratio_fine or min_bytes)
that races with the removal of the device leaves the global sum of minimum
dirty shares charged for a bdi that no longer exists. Until the next
reboot, that share of the dirty threshold is withheld from every other bdi
(__wb_calc_thresh() scales by 100 % minus the sum), and a later min_ratio
store on any bdi that would push the sum to 100 % fails with EINVAL
although every bdi reads 0. Root privilege is needed for the store; the
removal is any del_gendisk() (a disk or loop device going away) or the
unmount of a filesystem with its own bdi. On an x86_64 defconfig kernel
(v7.3-rc7), 2000 rounds of LOOP_CTL_ADD/LOOP_CTL_REMOVE on one loop device
with a second thread writing 50 to its min_ratio leak the share on the
first round the store lands in the window; afterwards `echo 99 >
min_ratio` on another loop device fails with EINVAL. With the fix the
same run keeps the sum at 0 and the store succeeds. Affected since v5.16,
when the reset in bdi_unregister() was added.
bdi_unregister() gives the bdi's share back with bdi_set_min_ratio(bdi, 0)
and only then calls device_unregister(), which removes the sysfs
attributes. A min_ratio_store() that gets its kernfs active reference
before the removal runs to completion after the reset:
__bdi_set_min_ratio() takes bdi_lock, sees bdi->min_ratio == 0, adds the
new value to bdi_min_ratio and stores it in the bdi, which bdi_put() then
frees. Nothing gives that share back.
Move the reset after device_unregister(): once the attributes are gone no
store can run, and bdi_set_min_ratio() needs nothing from the device.
Found while formally verifying bdi_unregister() against the kernel binary.
Link: https://lore.kernel.org/[email protected]
Fixes: 3c376dfafb ("mm: bdi: initialize bdi_min_ratio when bdi is unregistered")
Signed-off-by: Nickolai Zeldovich <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Reviewed-by: Jan Kara <[email protected]>
Assisted-by: LLM
Cc: David Hildenbrand <[email protected]>
Cc: Lorenzo Stoakes <[email protected]>
Cc: Liam R. Howlett <[email protected]>
Cc: Vlastimil Babka <[email protected]>
Cc: Mike Rapoport <[email protected]>
Cc: Suren Baghdasaryan <[email protected]>
Cc: Michal Hocko <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Manjong Lee <[email protected]>
This commit is contained in:
committed by
Andrew Morton
parent
1a2993227e
commit
b428f19668
+8
-7
@@ -1162,19 +1162,20 @@ void bdi_unregister(struct backing_dev_info *bdi)
|
||||
wb_shutdown(&bdi->wb);
|
||||
cgwb_bdi_unregister(bdi);
|
||||
|
||||
/*
|
||||
* If this BDI's min ratio has been set, use bdi_set_min_ratio() to
|
||||
* update the global bdi_min_ratio.
|
||||
*/
|
||||
if (bdi->min_ratio)
|
||||
bdi_set_min_ratio(bdi, 0);
|
||||
|
||||
if (bdi->dev) {
|
||||
bdi_debug_unregister(bdi);
|
||||
device_unregister(bdi->dev);
|
||||
bdi->dev = NULL;
|
||||
}
|
||||
|
||||
/*
|
||||
* If this BDI's min ratio has been set, use bdi_set_min_ratio() to
|
||||
* update the global bdi_min_ratio. After device_unregister(): the
|
||||
* sysfs min_ratio stores can no longer run and set it again.
|
||||
*/
|
||||
if (bdi->min_ratio)
|
||||
bdi_set_min_ratio(bdi, 0);
|
||||
|
||||
if (bdi->owner) {
|
||||
put_device(bdi->owner);
|
||||
bdi->owner = NULL;
|
||||
|
||||
Reference in New Issue
Block a user