mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
hwmon: (aht10) Fix update_interval overflow on 64-bit
On 64-bit, update_interval writes are clamped to LONG_MAX ms, but
ms_to_ktime() overflows above 9223372036854 ms and the interval wraps.
LONG_MAX becomes -1 ms, so every read starts a new measurement and
update_interval reads back -1.
Clamp to INT_MAX like sht4x, so the limit is the same on all platforms.
Fixes: 8c78f0dee4 ("hwmon: Add AHT10 Temperature and Humidity Sensor Driver")
Cc: [email protected]
Signed-off-by: Rupesh Majhi <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Guenter Roeck <[email protected]>
This commit is contained in:
committed by
Guenter Roeck
parent
68af85b730
commit
b5c5b67e02
@@ -222,7 +222,7 @@ static int aht10_read_values(struct aht10_data *data)
|
||||
static ssize_t aht10_interval_write(struct aht10_data *data,
|
||||
long val)
|
||||
{
|
||||
data->min_poll_interval = ms_to_ktime(clamp_val(val, 2000, LONG_MAX));
|
||||
data->min_poll_interval = ms_to_ktime(clamp_val(val, 2000, INT_MAX));
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user