mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
ALSA: aw2-alsa: select SND_PCM
Several stanzas in sound/pci/Kconfig select SND_PCM.
SND_AW2 selects nothing at all.
aw2-alsa calls snd_pcm_new, which sound/core/pcm.c provides under SND_PCM.
aw2-alsa.c:(.text+0x554): undefined reference to `snd_pcm_new'
4 symbols are undefined in all.
The driver can be built into vmlinux while SND_PCM is a module, in which
case the symbols are not there at link time.
Select rather than depend on: SND_PCM has no prompt of its own and is only
ever enabled by a select, so a depends on would leave SND_AW2
unselectable.
Reproduced on v7.3, arm64, with CONFIG_SND_AW2=y and CONFIG_SND_PCM=m.
Found with kreach, a static check that compares what Kconfig allows
against the symbols the compiled objects actually reference.
Fixes: 98f2a97f20 ("[ALSA] Emagic Audiowerk 2 ALSA driver.")
Signed-off-by: Jude Gyimah <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
This commit is contained in:
committed by
Takashi Iwai
parent
c58471d848
commit
bca568589a
@@ -141,6 +141,7 @@ config SND_AU8830
|
||||
|
||||
config SND_AW2
|
||||
tristate "Emagic Audiowerk 2"
|
||||
select SND_PCM
|
||||
help
|
||||
Say Y here to include support for Emagic Audiowerk 2 soundcards.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user