mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
mm/cma_debug: fix invalid accesses for inactive CMA areas
cma_activate_area() can fail after allocating range bitmaps. Its cleanup path frees those bitmaps, but only clears cma->count and cma->available_count. It leaves cma->nranges and each range's count in place, so cma_debugfs_init() can still register debugfs files for an area that never activated successfully. That exposes two problems. Reading the bitmap file can make debugfs walk a freed range bitmap and trigger an invalid memory access. Reading maxchunk can also take cma->lock even though that lock is initialized only on the successful activation path. Fix this by creating debugfs entries only for CMA areas that reached CMA_ACTIVATED.c009da4258introduced the invalid access to bitmap file.2e32b94760introduced the invalid access to cma->lock. This change applies to both issues. So I added two Fixes tags. Link: https://lore.kernel.org/[email protected] Fixes:c009da4258("mm, cma: support multiple contiguous ranges, if requested") Fixes:2e32b94760("mm: cma: add functions to get region pages counters") Signed-off-by: Muchun Song <[email protected]> Acked-by: Mike Rapoport (Microsoft) <[email protected]> Acked-by: Oscar Salvador (SUSE) <[email protected]> Acked-by: David Hildenbrand (Arm) <[email protected]> Cc: Dmitry Safonov <[email protected]> Cc: Frank van der Linden <[email protected]> Cc: Liam R. Howlett <[email protected]> Cc: Lorenzo Stoakes <[email protected]> Cc: Michal Hocko <[email protected]> Cc: Michal Nazarewicz <[email protected]> Cc: Stefan Strogin <[email protected]> Cc: Suren Baghdasaryan <[email protected]> Cc: Vlastimil Babka <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
This commit is contained in:
committed by
Andrew Morton
parent
c0cafe24d3
commit
c0ca59beb5
+2
-1
@@ -205,7 +205,8 @@ static int __init cma_debugfs_init(void)
|
||||
cma_debugfs_root = debugfs_create_dir("cma", NULL);
|
||||
|
||||
for (i = 0; i < cma_area_count; i++)
|
||||
cma_debugfs_add_one(&cma_areas[i], cma_debugfs_root);
|
||||
if (test_bit(CMA_ACTIVATED, &cma_areas[i].flags))
|
||||
cma_debugfs_add_one(&cma_areas[i], cma_debugfs_root);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user