mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
crypto: essiv - fix use-after-free in AEAD path
The request that ESSIV submits to its wrapped AEAD transform may
finish before crypto_aead_encrypt() or crypto_aead_decrypt() returns.
In case this happens, essiv_aead_done() calls aead_request_complete()
on the original ESSIV request, which can end up freeing the request
before essiv_aead_crypt() resumes, creating a UAF:
BUG: KASAN: slab-use-after-free in essiv_aead_crypt+0x8e6/0x950
Read of size 8 at addr ffff888102af1360 by task init/66
Check the return status before dereferencing rctx after submitting that
request. If the operation did not return -EINPROGRESS or -EBUSY, then
the request cannot have been freed yet.
Fixes: be1eb7f78a ("crypto: essiv - create wrapper template for ESSIV generation")
Cc: [email protected]
Assisted-by: LLM
Signed-off-by: Jérémy Jean <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
This commit is contained in:
+1
-1
@@ -250,7 +250,7 @@ static int essiv_aead_crypt(struct aead_request *req, bool enc)
|
||||
err = enc ? crypto_aead_encrypt(subreq) :
|
||||
crypto_aead_decrypt(subreq);
|
||||
|
||||
if (rctx->assoc && err != -EINPROGRESS && err != -EBUSY)
|
||||
if (err != -EINPROGRESS && err != -EBUSY)
|
||||
kfree(rctx->assoc);
|
||||
return err;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user