mirror of
https://github.com/torvalds/linux.git
synced 2026-11-20 13:03:48 +00:00
kernfs: avoid READ_ONCE() on a kgid_t in kernfs_new_node()
kernfs_new_node() reads the parent's gid with READ_ONCE(attrs->ia_gid).
That gid is a kgid_t, which is a struct.
On SMP alpha, READ_ONCE() ends by casting the value it loaded back to
the type of its argument. Here that is a cast from a struct to the same
struct. GCC accepts that as an extension, but ISO C does not allow a
cast to or from a struct type, so sparse warns:
fs/kernfs/dir.c:751:31: sparse: sparse: cast to non-scalar
fs/kernfs/dir.c:751:31: sparse: sparse: cast from non-scalar
Read the gid_t inside the kgid_t instead, and wrap it back up with
KGIDT_INIT(). This is still a single marked load of the same four bytes.
There is no functional change. With GCC 12 for alpha (the config from
the report) and GCC 14 for x86-64 (with and without KCSAN),
fs/kernfs/dir.o has the same object code before and after this change.
Fixes: 81bdc85b4c ("kernfs: fix up the unlocked attribute reads on the creation paths")
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Shakeel Butt <[email protected]>
Acked-by: Tejun Heo <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Danilo Krummrich <[email protected]>
This commit is contained in:
committed by
Danilo Krummrich
parent
14098e4966
commit
ef179363b0
+1
-1
@@ -750,7 +750,7 @@ struct kernfs_node *kernfs_new_node(struct kernfs_node *parent,
|
||||
struct kernfs_iattrs *attrs = READ_ONCE(parent->iattr);
|
||||
|
||||
if (attrs)
|
||||
gid = READ_ONCE(attrs->ia_gid);
|
||||
gid = KGIDT_INIT(READ_ONCE(attrs->ia_gid.val));
|
||||
|
||||
if (flags & KERNFS_DIR)
|
||||
mode |= S_ISGID;
|
||||
|
||||
Reference in New Issue
Block a user