lib/test_firmware: allocate the configured into_buf size

The batched into_buf test path allocates TEST_FIRMWARE_BUF_SIZE bytes
unconditionally, but then passes test_fw_config->buf_size to
request_firmware_into_buf() or request_partial_firmware_into_buf().

Userspace can set config_buf_size above TEST_FIRMWARE_BUF_SIZE before
triggering a batched request. If the firmware file is large enough, the
firmware loader writes past the end of the 1 KiB test buffer.

Allocate the buffer with the same size that the test passes to the firmware
API so config_buf_size remains the actual buffer size under test.

Assisted-by: Codex:gpt-5.5-cyber-preview
Link: https://lore.kernel.org/[email protected]
Signed-off-by: Samuel Moelius <[email protected]>
Reviewed-by: Andrew Morton <[email protected]>
Cc: Kees Cook <[email protected]>
Cc: Luis R. Rodriguez <[email protected]>
Cc: Scott Branden <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
This commit is contained in:
Samuel Moelius
2026-06-11 11:42:21 -07:00
committed by Andrew Morton
parent 89009392c8
commit f2737dc40d
+1 -1
View File
@@ -867,7 +867,7 @@ static int test_fw_run_batch_request(void *data)
if (test_fw_config->into_buf) {
void *test_buf;
test_buf = kzalloc(TEST_FIRMWARE_BUF_SIZE, GFP_KERNEL);
test_buf = kzalloc(test_fw_config->buf_size, GFP_KERNEL);
if (!test_buf)
return -ENOMEM;